feat(qsl): converge taxonomy and bundle governance#185
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Pigbibi
force-pushed
the
codex/qsl-governance-convergence-20260710
branch
from
f1985bb to
246fd8c
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1985bb2aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| issues: list[str], | ||
| ) -> None: | ||
| _, _, allowed_directions = _load_repo_tier_policy(compat_root) | ||
| dependency_repo_root = compat_root.parent / pin.repo |
There was a problem hiding this comment.
When qslctl is run with a --projects-root that is not --compat-root's parent (the CLI exposes these as independent options), this resolves dependency tiers from the wrong directory. In that setup the new direction gate either reads an unrelated sibling checkout or gets no qsl.toml and returns early via not dependency_tier, so forbidden outward dependencies in the selected workspace pass undetected. Resolve pin.repo from the consumer workspace (or pass projects_root) instead of compat_root.parent.
Useful? React with 👍 / 👎.
| @@ -251,6 +404,13 @@ def _check(repo_root: Path, compat_root: Path) -> tuple[bool, list[str], list[st | |||
| _validate_live_ref(legacy_ref, issues, warnings, enforce_bundle) | |||
There was a problem hiding this comment.
For repos that set allow_legacy=true and list constraints.txt/requirements.txt in live_constraint_files, this branch validates only the ref shape. A core repo can therefore put a full-SHA dependency on a strategy-lib repo in a live constraint file and avoid the new forbidden dependency direction check, even though live constraints only relax bundle-pin drift. Run _validate_dependency_direction for these managed refs as well.
Useful? React with 👍 / 👎.
Pigbibi
force-pushed
the
codex/qsl-governance-convergence-20260710
branch
from
246fd8c to
41df952
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
🤖 Codex PR ReviewPlease ensure a human reviewer checks this PR before merging. |
Co-Authored-By: Codex <noreply@openai.com>
Pigbibi
force-pushed
the
codex/qsl-governance-convergence-20260710
branch
from
41df952 to
0922bb9
Compare
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0922bb99c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "strategy-library": "strategy-lib", | ||
| "strategy_lib": "strategy-lib", | ||
| "runtime-platform": "runtime", | ||
| "runtime_plaform": "runtime", |
There was a problem hiding this comment.
If a legacy repo declares tier = "runtime_platform" (the underscore form this alias table appears to support, analogous to strategy_lib), _canonical_tier misses it because the key is misspelled as runtime_plaform. The new taxonomy check then reports an invalid tier instead of warning and canonicalizing to runtime, blocking qslctl check for those repos.
Useful? React with 👍 / 👎.
1 participant
Part of the QuantStrategyLab P0-P5 hardening and convergence wave.
Highlights:
Local validation was run before push in the Codex execution session.